In process_socket() when we create cs, should we explicitly set cs->pub.sense to CONN_SENSE_DEFAULT?
Otherwise, +1 (with a mmn bump). On Apr 19, 2013, at 6:09 PM, Graham Leggett <[email protected]> wrote: > On 19 Apr 2013, at 6:38 PM, Eric Covener <[email protected]> wrote: > >>> What would it take to make mod_ssl a non-clogging filter? >> >> Basically needs two things: >> 1) Never buffer data inside ssl (feasible I believe) >> 2) Create a new way for a filter deep inside the chain to indicate we >> need to wait for a read/write ability on a socket -- this >> fundamentally is why a Serf bucket model is better than our chained >> filters. An alternative approach would be changing the flow so >> filters don't directly call the next filter, putting the core back in >> control of filter flow, but this is still a non-trivial project. > > Would something like the attached patch work? > > Looking closer at mod_ssl, it seems that when it writes, it wires in both the > input and output filter stacks, which is good, but when it reads, only the > input filter stack is wired in, which means it can never write. This might > need to be looked at too. > > Regards, > Graham > -- > <httpd-unclog.patch>
