Hi,

while trying to fix bug #55426 I have found out that commit
http://svn.apache.org/r377292 is probably wrong. If my analysis is correct,
the first ap_get_status_line(...) call has to remain in the code, because
r->status_line is used right in the next call of ap_rvputs(...) and currently
this r->status_line is reflecting old status or is null.

It's true that r->status_line can be set by basic_http_header_check(...) later,
but in the case of dav_error_response we need r->status_line to be set earlier
to be able to call ap_rvputs(...).

Attached patch reverts the first part of r377292 and also fixes bug #55426 for
me.

Regards,
Jan Kaluza
Index: modules/dav/main/mod_dav.c
===================================================================
--- modules/dav/main/mod_dav.c	(revision 1520983)
+++ modules/dav/main/mod_dav.c	(working copy)
@@ -315,6 +315,7 @@
 static int dav_error_response(request_rec *r, int status, const char *body)
 {
     r->status = status;
+    r->status_line = ap_get_status_line(status);
 
     ap_set_content_type(r, "text/html; charset=ISO-8859-1");
 

Reply via email to