Hello Jim,
I voted for this change for backport to 2.4.8.
The fix looks solid to me at this time.
But I do have a couple of questions/ideas for the future.
1) proxy_schemes_t in modules/proxy/proxy_util.c and schemes_t in
apr-util/uri/apr_uri.c
are identical in structure and field names.
Could this be pulled to apr-util/include/apr_util.h in future
releases of apr-util?
2) Could mod_proxy_wstunnel.c benefit from a similar change as this
fix does for mod_proxy_http.c?
Thanks,
Mike Rumph
On 2/17/2014 12:42 PM, mru...@apache.org wrote:
Author: mrumph
Date: Mon Feb 17 20:42:15 2014
New Revision: 1569108
URL: http://svn.apache.org/r1569108
Log:
Vote for mod_proxy fix.
Modified:
httpd/httpd/branches/2.4.x/STATUS
Modified: httpd/httpd/branches/2.4.x/STATUS
URL:
http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1569108&r1=1569107&r2=1569108&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/STATUS (original)
+++ httpd/httpd/branches/2.4.x/STATUS Mon Feb 17 20:42:15 2014
@@ -98,6 +98,14 @@ RELEASE SHOWSTOPPERS:
PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
[ start all new proposals below, under PATCHES PROPOSED. ]
+ * mod_proxy: Use consistent canon formats for http, ajp and fcgi (if provided
+ port is the default port, don't add to canon URI). Ensures that ajp and
+ fcgi uses the defined workers and not the default generic reverse proxy
+ worker.
+ trunk patch: https://svn.apache.org/viewvc?view=revision&revision=1542562
+ 2.4.x patch: http://people.apache.org/~jim/patches/proxy-port-scheme.patch
+ +1: jim, druggeri, mrumph
+
PATCHES PROPOSED TO BACKPORT FROM TRUNK:
[ New proposals should be added at the end of the list ]
@@ -114,20 +122,11 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
without mod_request and mod_session present would cause the very
same failure. Would a warning in the release notes be good
enough?
- * mod_proxy: Use consistent canon formats for http, ajp and fcgi (if provided
- port is the default port, don't add to canon URI). Ensures that ajp and
- fcgi uses the defined workers and not the default generic reverse proxy
- worker.
- trunk patch: https://svn.apache.org/viewvc?view=revision&revision=1542562
- 2.4.x patch: http://people.apache.org/~jim/patches/proxy-port-scheme.patch
- +1: jim, druggeri
-
* prefork: PR: 54852. Only use a dummy_connection for idle processes
trunk patch: http://svn.apache.org/viewvc?view=revision&revision=1542379
2.4.x patch: trunk patch works mod CHANGES
+1: jim, covener
-
* FreeBSD: Disable IPv4-mapped listening sockets by default for versions
5+ instead of just for FreeBSD 5. PR 53824.
trunk patch: http://svn.apache.org/r1551685
