> -----Original Message----- > From: Joe Orton [mailto:jor...@redhat.com] > Sent: Mittwoch, 28. Mai 2014 15:43 > To: dev@httpd.apache.org > Subject: Re: Memory leak in mod_ssl ssl_callback_TmpDH > > On Wed, May 28, 2014 at 09:05:06AM +0200, Kaspar Brand wrote: > > Agree, CPU time is not a concern, get_dh_XXX() is only about populating > > DH with builtin constants (DH_generate_key happens at connection time, > > and is fast anyway). > > Ah, I did not realise. That is even more reason to do this at startup > then, surely. Users do complain (tho rarely) about modules which leak > across reloads, so it is worth caring about that too, and we can stay > with globals rather than polluting the module structure. > > Any objections? This seems cleaner than fussing around with atomics and > ignoring the race/leak.
Looks great. Care to commit? Regards Rüdiger
