Hi,

looking at PR56503, I was wondering why there is a call to 'ap_resolve_env' in 'ap_soak_end_container()' (config.c)

In this function there is:
> #if RESOLVE_ENV_PER_TOKEN
>         args = vb.buf;
> #else
>         args = ap_resolve_env(cmd->temp_pool, vb.buf);
> #endif

According to what I have seen, RESOLVE_ENV_PER_TOKEN is not defined, so the #else is taken.


Just keeping:
>         args = vb.buf;
looks logical to me because I don't really understand why we are expanding variables here.


According to doc, 'ap_soak_end_container()' is "Read[ing] all data between the current <foo> and the matching </foo>. All of this data is forgotten immediately."


I can't find any use case where expanding $(bar) [to something that could match the ending tag] would make sense.

Do you share my opinion?

Best regards,
CJ


Reply via email to