On Mon, Dec 1, 2014 at 4:08 PM, Graham Leggett <minf...@sharp.fm> wrote: > On 01 Dec 2014, at 12:03 PM, Yann Ylavic <ylavic....@gmail.com> wrote: > >> - The input filter seems to read and return blocksize bytes at once, >> couldn't it read up to readbytes - reabytes % blocksize, or even >> readbytes with retained buckets? >> It seems that buffering (at most blocksize[ - 1]) would benefit the >> output filter too (FLUSH). > > We buffer up to CryptoSize bytes (default: 128k) on both the input and output > filters, there is quite a song and dance to get this right.
OK, the other way around then (I thought osize was the block size), so it can read more bytes than asked to. This may also be unexpected by the caller... At least for the nonblocking case, I think we should return what we have so far (if any).
