On Tue, Dec 2, 2014 at 5:52 AM, Yann Ylavic <[email protected]> wrote: > Also, the old code notified unconditionally (too late, but always), > whereas now it will not should ap_start_lingering_close() fail in > start_lingering_close_blocking(). > > Shouldn't we : > > Index: server/mpm/event/event.c > =================================================================== > --- server/mpm/event/event.c (revision 1642684) > +++ server/mpm/event/event.c (working copy) > @@ -895,6 +895,8 @@ static int start_lingering_close_common(event_conn > static int start_lingering_close_blocking(event_conn_state_t *cs) > { > if (ap_start_lingering_close(cs->c)) { > + cs->c->sbh = NULL; > + notify_suspend(cs); > ap_push_pool(worker_queue_info, cs->p); > return 0; > } > return start_lingering_close_common(cs, 1); > }
+1 -- Eric Covener [email protected]
