The key issue I had with the lack of optional functions on the old NPN backport is addressed, that's great. Looks promising!
NPN is now irrelevant with ALPN, I presume? On Wed, Apr 29, 2015 at 6:05 AM, Kaspar Brand <httpd-dev.2...@velox.ch> wrote: > On 27.04.2015 17:04, Stefan Eissing wrote: > >> Am 25.04.2015 um 11:47 schrieb Kaspar Brand <httpd-dev.2...@velox.ch>: > >> Only tested in terms of "compiles both w/ and w/o HAVE_TLS_ALPN", so it > >> certainly needs more eyes before a backport proposal could be made. > >> There's also a "TODO: we should have a mod_ssl configuration parameter" > >> in ssl_engine_kernel.c which I'm unsure to what it refers. > > > > The „TODO“ is a leftover from before SSLAlpnPreference was introduced. > > It can be removed. > > I did some formatting cleanup in r1676709 and put a patch for 2.4.x > online under > https://people.apache.org/~kbrand/mod_ssl-2.4.x-alpn_2015-04-29.diff. > This should hopefully make it easier for people to test and review (it's > an amalgamation of ten revisions from trunk, see the top of the patch > file). > > Kaspar >
