On Sat, Jun 13, 2015 at 7:52 PM, Yann Ylavic <ylavic....@gmail.com> wrote:
> On Sat, Jun 13, 2015 at 8:49 PM, Jeff Trawick <traw...@gmail.com> wrote: > > > > Those that know the original patch would presumably have a better way to > > code this. > > > > I recall that httpd 1.3 generally added whitespace after the chunk size > as > > an optimization (pre-allocating space in BUFF for the largest possible > chunk > > size I guess). Is it appropriate to allow whitespace both before and > after? > > The patch above only allows it after. > > Committed in r1685345, by allowing both space and tab, before and > after the chunk-size. > Thinking more about it, I see no reason to allow spaces before > (especially if there is no compatibility issue), we probably should > revert that part. > Opinions? > 2.2 doesn't accept space or tab before the chunk size, so we don't need to accept that. 2.2 does accept spaces and tabs after the chunk size, so we do need to accept that. -- Born in Roswell... married an alien... http://emptyhammock.com/
