On Fri, Oct 30, 2015 at 4:04 PM, Plüm, Rüdiger, Vodafone Group <ruediger.pl...@vodafone.com> wrote: > > >> -----Ursprüngliche Nachricht----- >> Von: Yann Ylavic [mailto:ylavic....@gmail.com] >> Gesendet: Freitag, 30. Oktober 2015 15:40 >> An: dev@httpd.apache.org >> Betreff: Re: svn commit: r1711479 - in /httpd/httpd/trunk/server/mpm: >> event/event.c prefork/prefork.c worker/worker.c >> >> Hi Jan, >> >> On Fri, Oct 30, 2015 at 3:07 PM, <jkal...@apache.org> wrote: >> > Author: jkaluza >> > Date: Fri Oct 30 14:07:28 2015 >> > New Revision: 1711479 >> > >> > URL: http://svn.apache.org/viewvc?rev=1711479&view=rev >> > Log: >> > Fix crash in ap_mpm_pod_check call caused by NULL dereference of its >> parameter >> > when starting httpd as single process (httpd -X). >> > >> > Modified: >> > httpd/httpd/trunk/server/mpm/event/event.c >> > httpd/httpd/trunk/server/mpm/prefork/prefork.c >> > httpd/httpd/trunk/server/mpm/worker/worker.c >> >> Is that change also needed for event and worker? >> The old code (previous to r1705492 in 2.4.x) did not create the POD in >> one-process mode for those. > > We only call ap_mpm_pod_check in prefork and motorz.
We use the podx variant for worker and event. > So why is this needed for > worker and event? Sorry, I may have not been clear enough. My point is that this change/commit is *not* needed for event and worker, because (AFAICT) we don't touch the POD(x) in one-process mode, so we don't need to create it for these MPMs. Regards, Yann.
