On 15 Dec 2015, at 5:44 PM, Stefan Eissing <stefan.eiss...@greenbytes.de> wrote:
> However, there is another state in HTTP/2 processing, where a BLOCK_READ is > performed: flow control on streaming out responses. Basically, the client has > a window of n bytes, the server sends n response bytes and then needs to wait > for the client to increase the window again. This would be a good time to > resume processing back to the mpm, and initially I did so. But that breaks > under load. > > Under load, the event mpm feels free to close connections in certain states > - I think CONN_STATE_CHECK_REQUEST_LINE_READABLE. That is fine for a HTTP/1 > connection as it always is between requests here. But HTTP/2 would also like > to use read events, but unloading a child by closing such connections is not > the right thing to do. > > Is there a way mod_http2 can achieve this or do we need another flag in > conn_rec/cs? Does the CONN_STATE_WRITE_COMPLETION state fit this case? The WRITE in the above name is a bit of a misnomer, because when mod_ssl returns WANTS_READ we return to the CONN_STATE_WRITE_COMPLETION state with the sense set to READ. This tells the MPM to block waiting until we’re readable, as opposed to block waiting until we’re writable. > Observation 2: controlled close > HTTP/2 would like to send out a last frame when closing a connection in a > controlled/timeout way. Do we need another hook for that? Something like > "pre_close_connection”? I’m assuming we would like a module to have control over the sending of that frame, if so, it makes sense yes. > Observation 3: timeouts > a. If admins would like to have another Timeout for HTTP/2 connections, they > are currently stuck with configuring one Timeout which goes to > server_rec->timeout, right? For idle connections, clients already try to keep > it open longer. It would be nice to give admins a choice here for different > values based on the selected protocol. How to best do this? Perhaps just as we can override the sense of the connection before returning, we might be able to modify the timeout before returning. > b. Handling own timeouts: if I want, during processing the connection, a > different socket timeout, I can just set it using apr_socket_timeout_set()? > Shall I restore it back to server->timeout before returning? That feels wrong, ideally we want to be formally telling the MPM “give us this timeout” rather than doing something sneaky behind it’s back. > c. What would be the best way to wait for a file description *and* > conditional event simultaneously? mod_http2 has now a sort of pool loop with > double backup timer for situations where it needs to watch both client and > backend processes. I’m not sure how portable it is watching for file descriptors. I have used libev to do this in the past and it was quite involved. However - if we can support this it would be really useful. Regards, Graham —
