Hmmm For some reason, I don't get the error, even though I build w/ --enable-maintainer-mode
Thx! > On Jan 11, 2016, at 7:57 AM, Plüm, Rüdiger, Vodafone Group > <ruediger.pl...@vodafone.com> wrote: > > Did a > > make extraclean > /dev/null; ./buildconf; ./config.nice; make -j 4 > /dev/null > > and the warning makes sense to me since we create the static in every file > where we include > mod_proxy.h. If we really need it available everywhere, I guess we should > define it in mod_proxy.c > as global non static and have an extern in mod_proxy.h. Otherwise we create > this static data in > each object file separately that includes mod_proxy.h. > > Regards > > Rüdiger > >> -----Ursprüngliche Nachricht----- >> Von: Jim Jagielski [mailto:j...@jagunet.com] >> Gesendet: Montag, 11. Januar 2016 13:43 >> An: dev@httpd.apache.org >> Betreff: Re: svn commit: r1723953 - in /httpd/httpd/trunk/modules/proxy: >> mod_proxy.h mod_proxy_hcheck.c >> >> I can't recreate that... did you do a clean build? >> >>> On Jan 11, 2016, at 4:56 AM, Ruediger Pluem <rpl...@apache.org> wrote: >>> >>> >>> >>> On 01/10/2016 08:20 PM, j...@apache.org wrote: >>>> Author: jim >>>> Date: Sun Jan 10 19:20:31 2016 >>>> New Revision: 1723953 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=1723953&view=rev >>>> Log: >>>> Use enums and structs to keep things better organized >>>> >>>> Modified: >>>> httpd/httpd/trunk/modules/proxy/mod_proxy.h >>>> httpd/httpd/trunk/modules/proxy/mod_proxy_hcheck.c >>>> >>>> Modified: httpd/httpd/trunk/modules/proxy/mod_proxy.h >>>> URL: >> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy.h >> ?rev=1723953&r1=1723952&r2=1723953&view=diff >>>> >> ======================================================================== >> ====== >>>> --- httpd/httpd/trunk/modules/proxy/mod_proxy.h (original) >>>> +++ httpd/httpd/trunk/modules/proxy/mod_proxy.h Sun Jan 10 19:20:31 >> 2016 >>>> @@ -75,6 +75,26 @@ enum enctype { >>>> enc_path, enc_search, enc_user, enc_fpath, enc_parm >>>> }; >>>> >>>> +typedef enum { >>>> + NONE, TCP, OPTIONS, HEAD, GET, CPING, PROVIDER, EOT >>>> +} hcmethod_t; >>>> + >>>> +typedef struct { >>>> + hcmethod_t method; >>>> + char *name; >>>> +} hcmethods_t; >>>> + >>>> +static hcmethods_t hcmethods[] = { >>>> + {NONE, "NONE"}, >>>> + {TCP, "TCP"}, >>>> + {OPTIONS, "OPTIONS"}, >>>> + {HEAD, "HEAD"}, >>>> + {GET, "GET"}, >>>> + {CPING, "CPING"}, >>>> + {PROVIDER, "PROVIDER"}, >>>> + {EOT, NULL} >>>> +}; >>> >>> Shouldn't the above move over to mod_proxy.c ? >>> >>> Otherwise we see >>> >>> mod_proxy.h:87: warning: ‘hcmethods’ defined but not used >>> >>> numerous time from c files where mod_proxy.h gets included but >> hcmethods not used. >>> >>> Regards >>> >>> Rüdiger >
