On Fri, Mar 18, 2016 at 5:06 PM, Jeff Trawick <traw...@gmail.com> wrote: > On Thu, Mar 10, 2016 at 7:31 AM, <yla...@apache.org> wrote: >> >> Author: ylavic >> Date: Thu Mar 10 12:31:13 2016 >> New Revision: 1734396 >> >> URL: http://svn.apache.org/viewvc?rev=1734396&view=rev >> Log: >> Merge r1734006 from trunk: >> >> mod_ssl: Don't lose track of the SSL context if the >> ssl_run_pre_handshake() >> hook returns an error. > > > The ssl_run_pre_handshake() hook doesn't exist in the 2.4.x branch. I would > rather like it to exist there and will propose so after some testing, but it > isn't yet clear that the CHANGES entry will make sense for httpd 2.4.19. > (We'll see.)
I think the backport worth it because in 2.4.x like in trunk, we could also (unlikely) fail in SSL_set_session_id_context(), and likewise lose track of sslconn->ssl. Maybe s/ssl_run_pre_handshake/SSL_set_session_id_context/ in CHANGES?