On 05/12/2016 07:31 AM, Evgeny Kotkov wrote:
@@ -451,11 +452,11 @@
  SET(mod_proxy_wstunnel_extra_libs    mod_proxy)
  SET(mod_proxy_http2_requires               NGHTTP2_FOUND)
  SET(mod_proxy_http2_extra_defines          ssize_t=long)
-SET(mod_proxy_http2_extra_libs             ${NGHTTP2_LIBRARIES})
+SET(mod_proxy_http2_extra_includes         ${NGHTTP2_INCLUDE_DIR})
+SET(mod_proxy_http2_extra_libs             ${NGHTTP2_LIBRARIES} mod_proxy)
  SET(mod_proxy_http2_extra_sources
    modules/http2/h2_proxy_session.c   modules/http2/h2_util.c
  )
-SET(mod_proxy_http2_extra_libs       mod_proxy)
  SET(mod_ratelimit_extra_defines      AP_RL_DECLARE_EXPORT)
  SET(mod_sed_extra_sources
    modules/filters/regexp.c           modules/filters/sed0.c

+1 especially to the _extra_libs change (see also my prior attempt [1] at a patch for this). Should mod_http2 be added to the _extra_libs as well, or has that dependency been broken? The last time I took a look at this was in February, and I assume multiple things have changed since then.

I don't have Windows readily available to test this week, so I can't give a "works for me" yet.

--Jacob

[1] https://github.com/jchampio/httpd/commit/06edc06a42c8ccac5970cc7b4aa7cee84db346a2

Reply via email to