On Tue, Jun 28, 2016 at 10:20 AM, Yann Ylavic <ylavic....@gmail.com> wrote:
> On Tue, Jun 28, 2016 at 5:12 PM, William A Rowe Jr <wr...@rowe-clan.net> > wrote: > > On Tue, Jun 28, 2016 at 10:10 AM, Yann Ylavic <ylavic....@gmail.com> > wrote: > >> > >> On Tue, Jun 28, 2016 at 5:06 PM, Yann Ylavic <ylavic....@gmail.com> > wrote: > >> > On Tue, Jun 28, 2016 at 5:04 PM, Yann Ylavic <ylavic....@gmail.com> > >> > wrote: > >> >> > >> >> I don't see where lbmethod_heartbeat depends on mod_heartmonitor in > >> >> the code, but it seems to require mod_slotmem_shm though. > >> > > >> > My bad, mod_heartmonitor is required too. > >> > >> Actually lbmethod_heartbeat seems to fall back to using the filesystem > >> when mod_heartmonitor is missing, so it's not really a (configure) > >> requirement IMHO. > > > > > > Thanks for the validation. Some updates to the lbmethod_heartbeat module > > docs might be helpful. > > Regarding dependency on mod_slotmem(_shm), is it a requirement of > mod_proxy_balancer already (it should)? > While I agree, taking the enable_proxy_balancer (yes|shared|static) value as the default will cause the APACHE_MODULE macro to evaluate building every lbmethod dependency as required (and fail if not available), as if they were explicitly enabled. I'd like to avoid repeating the logic we used in config.m4 from mod_proxy, but adding another dependency could cause configure to bomb when a module is disabled. I think we can add more dependencies this after 2.4.23 is tagged.
