On Wed, Aug 3, 2016 at 4:58 PM, William A Rowe Jr <[email protected]> wrote:
> On Wed, Aug 3, 2016 at 3:21 PM, Jacob Champion <[email protected]> >> wrote: >> >>> >>> I don't think this is an equivalent transformation. More logic below >>> this case relies on the last_field NULL check, and I'm currently getting >>> segfaults on trunk due to the strchr on line 907. >>> >> >> You were correct, that was my oversight. It was easier to simply revert > the > work so that I'm not overlaying one whitespace change after another, since > the fix causes everything to be re-indented anyways, so we are back to > trunk of last evening before my patches this morning. > And I've reapplied the now-corrected logic. Thanks for your detailed and careful review of these changes, please feel free to review this code again offer any feedback. We'll fix the obs-fold whitespace question next. Cheers, Bill
