On Fri, Aug 5, 2016 at 12:50 PM, Yann Ylavic <ylavic....@gmail.com> wrote:
> > while adding > > the unnecessary verification of last_len != 0 from line 904, so I'd say > it's > > a > > net loss of legibility in spite of gaining us 4 characters. Just my 2c. > > The 'len' verification is necessary because it can be zero when > last_field is NULL (legitimately, no headers at all), and we must > leave still. > I thought that was a bug, but you caught it in the no-lines case by hitting the trailing while() test. What I referred to was the continue from line 904 where we had merged an obs-fold, where can't have an empty last_len, so the test from that continue is a wasted cycle.
