Hi,

I was about to start to submit backport proposals related to 'ap_cstr_casecmp'. The goal is to synch 2.4 and trunk a bit more.
This should not be a that easy task because:
   - initial updates are big patches
- they mix code already backported and code that are only in trunk (svn merge will give some errors)
   - strcasecmp --> ap_casecmpstr --> ap_cstr_casecmp


Anyway, while looking at it, I noticed the code below.
I think that it is a leftover because I don't see any reason to handle these 2 string comparisons differently.

CJ


Le 23/11/2015 à 17:48, [email protected] a écrit :
Author: ylavic
Date: Mon Nov 23 16:48:35 2015
New Revision: 1715880

URL: http://svn.apache.org/viewvc?rev=1715880&view=rev
Log:
More ap_casecmpstr[n]() usages.

Modified:
     [...]
     httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
[...]
Modified: httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
URL: 
http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/aaa/mod_auth_digest.c?rev=1715880&r1=1715879&r2=1715880&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/aaa/mod_auth_digest.c (original)
+++ httpd/httpd/trunk/modules/aaa/mod_auth_digest.c Mon Nov 23 16:48:35 2015
@@ -542,7 +542,7 @@ static const char *set_qop(cmd_parms *cm
      if (!strcasecmp(op, "auth-int")) {
strcasecmp unchanged here.

          return "AuthDigestQop auth-int is not implemented";
      }
-    else if (strcasecmp(op, "auth")) {
+    else if (ap_casecmpstr(op, "auth")) {
but updated there.
          return apr_pstrcat(cmd->pool, "Unrecognized qop: ", op, NULL);
      }
  [...]


---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel 
antivirus Avast.
https://www.avast.com/antivirus

Reply via email to