On 07/13/2016 09:55 AM, Ruediger Pluem wrote: > > > On 07/13/2016 09:24 AM, Ruediger Pluem wrote: >> >> >> On 07/12/2016 11:16 PM, Graham Leggett wrote: >>> On 11 Jul 2016, at 4:39 PM, Ruediger Pluem <[email protected]> wrote: >>> >>>>> Added: httpd/httpd/trunk/modules/filters/mod_crypto.c >>>>> URL: >>>>> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_crypto.c?rev=1752099&view=auto >>>>> ============================================================================== >>>>> --- httpd/httpd/trunk/modules/filters/mod_crypto.c (added) >>>>> +++ httpd/httpd/trunk/modules/filters/mod_crypto.c Sun Jul 10 17:27:03 >>>>> 2016 >>>> >>>>> +static void *merge_crypto_config(apr_pool_t * p, void *basev, void *addv) >>>>> +{ >>>>> + crypto_conf *new = (crypto_conf *) apr_pcalloc(p, >>>>> sizeof(crypto_conf)); >>>>> + crypto_conf *add = (crypto_conf *) addv; >>>>> + crypto_conf *base = (crypto_conf *) basev; >>>>> + >>>>> + new->library = (add->library_set == 0) ? base->library : >>>>> add->library; >>>>> + new->params = (add->library_set == 0) ? base->params : add->params; >>>>> + new->library_set = add->library_set || base->library_set; >>>>> + >>>>> + new->crypto = base->crypto; >>>> >>>> Shouldn't this be: >>>> >>>> new->crypto = add->crypto; >>> >>> In this case no, the value of crypto is set globally and needs to be unique >>> across the server. >>> >> > > If it is only used globally you could even think of kicking it out of the > server config and > have it as a static in the module. For access from outside the module if > needed at all an optional function could be used. >
Opinions? Regards Rüdiger
