> -----Original Message-----
> From: Evgeny Kotkov [mailto:evgeny.kot...@visualsvn.com]
> Sent: Donnerstag, 22. September 2016 00:17
> To: dev@httpd.apache.org
> Subject: Re: svn commit: r1761714 - in /httpd/httpd/trunk: CHANGES
> CMakeLists.txt docs/log-message-tags/next-number modules/filters/config.m4
> modules/filters/mod_brotli.c os/win32/BaseAddr.ref
> 
> Ruediger Pluem <rpl...@apache.org> writes:
> 
> >> +    ac_brotli_libs="${ac_brotli_libs:--lbrotlienc `$apr_config --
> libs`} "
> >> +    APR_ADDTO(MOD_LDFLAGS, [$ac_brotli_libs])
> >
> > This breaks compilation of trunk if libbrotlienc is not present as it is
> > added unconditionally. But even if would be added conditionally I sense
> > that all filters would be linked against libbrotlienc. So better only
> add
> > to MOD_BROTLI_LDADD instead of MOD_LDFLAGS
> 
> Indeed, I totally messed up this part of the configuration script.  Sorry
> for that.
> 
> I committed a rework of this part in r1761824 [1], and it fixes this build
> issue for me.  Could you please check it in your environment as well?

Yes, this fixes it. Thanks.

Regards

Rüdiger

Reply via email to