On Fri, Nov 4, 2016 at 9:14 PM, William A Rowe Jr <wr...@rowe-clan.net> wrote:
> On Fri, Nov 4, 2016 at 5:17 PM, Yann Ylavic <ylavic....@gmail.com> wrote: > >> On Fri, Nov 4, 2016 at 10:15 PM, William A Rowe Jr <wr...@rowe-clan.net> >> wrote: >> > I'm really not clear how ap_map_http_request_error() arrived without the >> > patch patch below, and unclear whether it does what the backport >> proposal >> > intended with this work omitted. >> > >> > 1482522 minfrin >> > core: Stop the HTTP_IN filter from attempting to write error buckets >> > to the output filters, which is bogus in the proxy case. Create a >> > clean mapping from APR codes to HTTP status codes, and use it where >> > needed. >> >> The above was backported in 2.4.13 ([1]+[2]) and 2.2.30 ([3]), though >> not exactly the same way as implemented in r1482522 (yet the intent is >> there, and the issue fixed ;) >> > > Ahhh, that's cool. > > >> What differed is that http_filters' bail_out_on_error() was preserved >> (so that [third-party-]modules don't notice/have to handle the >> response themselves) > > Which would be a brilliant solution if -static apr_status_t bail_out_on_error(http_ctx_t *ctx, - ap_filter_t *f, - int http_error) Wasn't a private, unexported entry point on every sane C compiler. Sigh...
