On Wed, Dec 14, 2016 at 11:30 PM, William A Rowe Jr <[email protected]> wrote:
> On Wed, Dec 14, 2016 at 2:51 AM, Joe Orton <[email protected]> wrote: > >> >> I adjusted the test case to cope with a sed which adds a trailing >> newline now, does that pass with OS X sed? I'm yet to work out why the >> test cases passes in trunk and fails in 2.4, mod_ext_filter is the same >> in both branches. >> > > Seeing different issues on Fedora 24 under 2.x and 2.4 branches > On 2.4 branch, everything seems to go sideways; > > t/modules/ext_filter.t .............. 1/24 > # Failed test 2 in t/modules/ext_filter.t at line 26 > # Failed test 5 in t/modules/ext_filter.t at line 36 > # Failed test 6 in t/modules/ext_filter.t at line 37 > # Failed test 7 in t/modules/ext_filter.t at line 36 fail #2 > # Failed test 8 in t/modules/ext_filter.t at line 37 fail #2 > # Failed test 9 in t/modules/ext_filter.t at line 36 fail #3 > # Failed test 10 in t/modules/ext_filter.t at line 37 fail #3 > # Failed test 11 in t/modules/ext_filter.t at line 36 fail #4 > # Failed test 12 in t/modules/ext_filter.t at line 37 fail #4 > # Failed test 13 in t/modules/ext_filter.t at line 36 fail #5 > # Failed test 14 in t/modules/ext_filter.t at line 37 fail #5 > # Failed test 15 in t/modules/ext_filter.t at line 36 fail #6 > # Failed test 16 in t/modules/ext_filter.t at line 37 fail #6 > # Failed test 17 in t/modules/ext_filter.t at line 36 fail #7 > # Failed test 18 in t/modules/ext_filter.t at line 37 fail #7 > # Failed test 19 in t/modules/ext_filter.t at line 36 fail #8 > # Failed test 20 in t/modules/ext_filter.t at line 37 fail #8 > # Failed test 21 in t/modules/ext_filter.t at line 36 fail #9 > # Failed test 22 in t/modules/ext_filter.t at line 37 fail #9 > # Failed test 23 in t/modules/ext_filter.t at line 36 fail #10 > # Failed test 24 in t/modules/ext_filter.t at line 37 fail #10 > t/modules/ext_filter.t .............. Failed 21/24 subtests > > I don't see anything else wrong on 2.4 branch except for > > t/modules/rewrite.t ................. 1/34 # Failed test 34 in > t/modules/rewrite.t at line 120 > t/modules/rewrite.t ................. Failed 1/34 subtests > (1 TODO test unexpectedly succeeded) > > But I have not yet caught up with the latest commits to rewrite. > > Thinking that on 2.4 branch, a poorly performing retest against 2.4.23 > is all that is needed to proceed to release, and then return to address > later as not-a-regression. > On 2.3.23, indeed this doesn't look like a regression (test 2 again fails on the missing perl script); t/modules/ext_filter.t .............. 1/24 # Failed test 2 in t/modules/ext_filter.t at line 26 # Failed test 5 in t/modules/ext_filter.t at line 36 # Failed test 6 in t/modules/ext_filter.t at line 37 # Failed test 7 in t/modules/ext_filter.t at line 36 fail #2 # Failed test 8 in t/modules/ext_filter.t at line 37 fail #2 # Failed test 9 in t/modules/ext_filter.t at line 36 fail #3 # Failed test 10 in t/modules/ext_filter.t at line 37 fail #3 # Failed test 11 in t/modules/ext_filter.t at line 36 fail #4 # Failed test 12 in t/modules/ext_filter.t at line 37 fail #4 # Failed test 13 in t/modules/ext_filter.t at line 36 fail #5 # Failed test 14 in t/modules/ext_filter.t at line 37 fail #5 # Failed test 15 in t/modules/ext_filter.t at line 36 fail #6 # Failed test 16 in t/modules/ext_filter.t at line 37 fail #6 # Failed test 17 in t/modules/ext_filter.t at line 36 fail #7 # Failed test 18 in t/modules/ext_filter.t at line 37 fail #7 # Failed test 19 in t/modules/ext_filter.t at line 36 fail #8 # Failed test 20 in t/modules/ext_filter.t at line 37 fail #8 # Failed test 21 in t/modules/ext_filter.t at line 36 fail #9 # Failed test 22 in t/modules/ext_filter.t at line 37 fail #9 # Failed test 23 in t/modules/ext_filter.t at line 36 fail #10 # Failed test 24 in t/modules/ext_filter.t at line 37 fail #10 t/modules/ext_filter.t .............. Failed 21/24 subtests I'd think we are fine to proceed to 2.4.24 tag, this isn't a regression.
