> Am 20.01.2017 um 21:59 schrieb Jim Jagielski <j...@jagunet.com>:
> 
> 
>> On Jan 19, 2017, at 4:00 PM, Ruediger Pluem <rpl...@apache.org> wrote:
>> 
>> 
>> 
>> On 01/19/2017 09:38 PM, ic...@apache.org wrote:
>>> Author: icing
>>> Date: Thu Jan 19 20:38:50 2017
>>> New Revision: 1779525
>>> 
>>> URL: http://svn.apache.org/viewvc?rev=1779525&view=rev
>>> Log:
>>> On the trunk:
>>> 
>>> mod_http2: decoupling lifetime of mplx pool from h2_session which messed up 
>>> the cleanup ordering.
>>> 
>>> 
>>> Modified:
>>>   httpd/httpd/trunk/modules/http2/h2_mplx.c
>>> 
>>> Modified: httpd/httpd/trunk/modules/http2/h2_mplx.c
>>> URL: 
>>> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/h2_mplx.c?rev=1779525&r1=1779524&r2=1779525&view=diff
>>> ==============================================================================
>>> --- httpd/httpd/trunk/modules/http2/h2_mplx.c (original)
>>> +++ httpd/httpd/trunk/modules/http2/h2_mplx.c Thu Jan 19 20:38:50 2017
>>> @@ -280,7 +280,7 @@ h2_mplx *h2_mplx_create(conn_rec *c, apr
>>>        m->id = c->id;
>>>        APR_RING_ELEM_INIT(m, link);
>>>        m->c = c;
>>> -        apr_pool_create_ex(&m->pool, parent, NULL, allocator);
>>> +        apr_pool_create_ex(&m->pool, NULL, NULL, allocator);
>> 
>> Without further investigations: Global pools always make me worry. Are you 
>> sure we don't introduce
>> a memory leak here?
>> 
> 
> Especially untagged ones!

Has already been reverted.

Stefan Eissing

<green/>bytes GmbH
Hafenstrasse 16
48155 Münster
www.greenbytes.de

Reply via email to