On Fri, Feb 17, 2017 at 12:18 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > On Thu, Feb 16, 2017 at 4:45 PM, Yann Ylavic <ylavic....@gmail.com> wrote: >> >> Shouldn't this commit (and follow ups) be merged in >> branches/2.4.x-openssl-1.1.0-compat ? > > Yes; however it isn't clear to me what that branch is; a patch management > branch? or something else?
Not sure either, I think Rainer first created it for the merge, but since it was later rebased I don't know. Not sure it is fully synchronized either. > > Also wondering if the follow-up patch is actually required... wouldn't we be > just as safe using BIO_s_file() with older openssl flavors? I found the patch > in the early work on compatibility, but it seems we've dropped the conditional > in the current trunk/ sources. BIO_s_file_internal() seems to be a WIN16 thing, so I guess we can remove it :)