> Shouldn't we check that this is used GLOBAL_ONLY? > > ap_check_cmd_context(cmd, GLOBAL_ONLY); >
>> Modified: httpd/httpd/trunk/server/mpm/prefork/prefork.c >> URL: >> http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm/prefork/prefork.c?rev=1820098&r1=1820097&r2=1820098&view=diff >> ============================================================================== >> --- httpd/httpd/trunk/server/mpm/prefork/prefork.c (original) >> +++ httpd/httpd/trunk/server/mpm/prefork/prefork.c Thu Jan 4 15:10:45 2018 >> @@ -600,7 +600,12 @@ static void child_main(int child_num_arg >> /* resource shortage or should-not-occur occurred */ >> clean_child_exit(APEXIT_CHILDSICK); >> } >> - else if (status != APR_SUCCESS) { >> + else if (ap_accept_error_is_nonfatal(rc)) { > > I guess else if is not needed and if is sufficient as clean_child_exit never > returns. > >> + ap_log_error(APLOG_MARK, APLOG_DEBUG, rc, ap_server_conf, > > I guess status should be used instead of rc in the two lines above. Thanks! 1820113.
