On Sun, Feb 18, 2018 at 8:44 AM, Steffen <[email protected]> wrote: > > The bad one: > > -- mod_remoteip.obj : error LNK2019: unresolved external symbol > __imp__ntohs@4 referenced in function _remoteip_input_filter >
cmake or dsp? If you are using the dsp files, my guess is to change the LINK32 lines to include ws2_32.lib mswsock.lib after kernel32.lib. I don't have an env to try. IIUC cmake already does this for all modules. but you can see it explicitly in some modules' dsp files. > -- not sure, mod_md; should curl and jansson be added to notice/license > files ? I don't think either is contained in mod_md, so I don't think they should be referenced in the NOTICES: http://www.apache.org/dev/licensing-howto.html#mod-notice ``` Dependencies which are not included in the distribution MUST NOT be added to LICENSE and NOTICE. As far as LICENSE and NOTICE are concerned, only bundled bits matter. ```
