On Fri, Sep 7, 2018 at 2:21 AM William A Rowe Jr <wr...@rowe-clan.net> wrote: > > I'd suggest you did a better job in the commit log explaning this than in the > doxygen where it really is needed.
OK, I can do this when moving the declaration to a more private location. > > Private declares don't belong in util_filter.h IMO. Agreed, actually I just discovered "server/core.h", sounds reasonable? There probably are other "includes/" candidates, like: ap_expr_init (ap_expr.h) ap_open_logs (http_log.h) ap_logs_child_init (http_log.h) ap_add_output_filters_by_type (http_core.h) ap_core_reorder_directories (http_core.h) ap_process_async_request (http_request.h) ap_create_scoreboard (scoreboard.h) ap_http_filter (mod_core.h) ap_http_chunk_filter (mod_core.h) ap_http_outerror_filter (mod_core.h) ap_response_code_string (mod_core.h) util_ldap_cache_init (util_ldap.h) util_ald_cache_display (util_ldap.h) ... Shouldn't we do something fot them too? Regards, Yann.
