On Wed, Sep 12, 2018 at 7:59 PM Yann Ylavic <ylavic....@gmail.com> wrote: > > On Wed, Sep 12, 2018 at 5:53 PM Eric Covener <cove...@gmail.com> wrote: > > > > Forking from the Cool Stuff thread. > > > > Have you noticed that the wstunnell stuff makes the suspended count in > > the MPM grow? There is no API for us to tell the MPM that when we get > > the socket-activity callback that we are "resuming" something. > > > > (going from vague recollection) > > It seems that we increment it once when the handler returns SUSPENDED, > and decrement it once per connection too in proxy_wstunnel_finish().
This didn't even ring a bell :) But won't we return SUSPENDED many times to a single finish? > > However, looks like there is unnecessary churn > proxy_wstunnel_finish(), including a double close since the MPM will > also finally close the client connection. How about something like the > attached? Looks reasonable.
