> Am 09.05.2019 um 11:32 schrieb Yann Ylavic <[email protected]>:
> 
> The issue is more that the hooks in eor_bucket_cleanup() will be run
> multiple times, rather than a lifetime issue.

I read it like this:
The cleanup is only registered on the first creation. The copy never registers. 
But the bucket_destroy calls the pool destroy each time.

> 
> On Thu, May 9, 2019 at 11:28 AM Yann Ylavic <[email protected]> wrote:
>> 
>> No it's not actually, nevermind.
>> 
>> On Thu, May 9, 2019 at 11:24 AM Yann Ylavic <[email protected]> wrote:
>>> 
>>> Hmm, if r->pool gets destroyed by the first eor, the
>>> eor_bucket_cleanup() for the copy should NULLify its b->data at the
>>> same time, so it should be safe no?
>>> 
>>> On Thu, May 9, 2019 at 11:22 AM Plüm, Rüdiger, Vodafone Group
>>> <[email protected]> wrote:
>>>> 
>>>> I think your understanding is correct.
>>>> 
>>>> Regards
>>>> 
>>>> Rüdiger
>>>> 
>>>> 
>>>> C2 General
>>>> 
>>>>> -----Ursprüngliche Nachricht-----
>>>>> Von: Stefan Eissing <[email protected]>
>>>>> Gesendet: Donnerstag, 9. Mai 2019 11:02
>>>>> An: [email protected]
>>>>> Betreff: eor bucket
>>>>> 
>>>>> Could someone help me to check my understanding of the eor bucket
>>>>> implementation?
>>>>> 
>>>>> If an eor bucket is ever copied, there are 2 buckets with their b->data
>>>>> pointing to the request_rec. Since this is local to the bucket,
>>>>> destroying these 2 will call apr_pool_destroy() twice on the pool.
>>>>> Correct?
>>>>> 
>>>>> -Stefan

Reply via email to