However, it fixed it by ignoring most of the troubles... I have my IP unblocked, so I'm able to get some further fixes in, I added the iterator, confirmed the newest fixes and have committed to trunk and 2.4.x. Steve, please retest and report back?
There is no such thing as a _102 openssl result macro, that was a big whoops, since we never tested for that. And won't need to, ever again... deleted the openssl rev test (who would build such an unsupported ancient thing anyways? Shame on them.) And immediately failed on curl and jansson but for two different reasons - reminding us that copy-paste isn't always our friend. cmake has *long* had a FIND_PACKAGE for curl. Not so much for jansson. But we didn't follow the missing logic for jansson or for curl, and didn't invoke the find facility for curl, so both were AWOL. Didn't matter with my hack, since we didn't look for them to be found, and the way I build, all the libs and includes are found during the compilation at the anticipated paths... all but the libcurl_imp.lib which the existing cmake logic overlooked. Easily hardcoded as; cmake $(CMAKE_DEFAULTS) -D CMAKE_INSTALL_PREFIX=$(DESTDIR) \ -D CURL_LIBRARIES=$(DESTDIR)/lib/libcurl_imp.lib The lesson in this is that there is more to script than what was copied, it was no different than asking configure.in to work given only half the necessary lines of configure script, and there are one of two different patterns that must be followed; either a FIND_PACKAGE implementation is available in common flavors of cmake for a specific package, or is not. I guess the ask is not to commit untested build changes, well at least don't backport them. The current state of CMake against 3.14 carries the following warnings, I may or may not get around to addressing some or all of these, if anyone else is looking for some low hanging fruit... CMake Warning (dev) at CMakeLists.txt:563 (ELSEIF): Policy CMP0054 is not set: Only interpret if() arguments as variables or keywords when unquoted. Run "cmake --help-policy CMP0054" for policy details. Use the cmake_policy command to set the policy and suppress this warning. Quoted variables like "i" will no longer be dereferenced when the policy is set to NEW. Since the policy is not set the OLD behavior will be used. This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at CMakeLists.txt:615 (GET_TARGET_PROPERTY): Policy CMP0026 is not set: Disallow use of the LOCATION target property. Run "cmake --help-policy CMP0026" for policy details. Use the cmake_policy command to set the policy and suppress this warning. The LOCATION property should not be read from target "gen_test_char". Use the target name directly with add_custom_command, or use the generator expression $<TARGET_FILE>, as appropriate. This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at CMakeLists.txt:120 (ELSEIF): Policy CMP0054 is not set: Only interpret if() arguments as variables or keywords when unquoted. Run "cmake --help-policy CMP0054" for policy details. Use the cmake_policy command to set the policy and suppress this warning. Quoted variables like "i" will no longer be dereferenced when the policy is set to NEW. Since the policy is not set the OLD behavior will be used. Call Stack (most recent call first): CMakeLists.txt:757 (GET_MOD_ENABLE_RANK) This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at CMakeLists.txt:766 (IF): Policy CMP0054 is not set: Only interpret if() arguments as variables or keywords when unquoted. Run "cmake --help-policy CMP0054" for policy details. Use the cmake_policy command to set the policy and suppress this warning. Quoted variables like "APR_HAS_LDAP" will no longer be dereferenced when the policy is set to NEW. Since the policy is not set the OLD behavior will be used. This warning is for project developers. Use -Wno-dev to suppress it. On Fri, Aug 30, 2019 at 2:24 AM Steve Hay <[email protected]> wrote: > Thanks to you both - that was indeed the trouble, and the fix has > sorted it out for me. > > On Fri, 30 Aug 2019 at 08:16, Stefan Eissing > <[email protected]> wrote: > > > > Added to trunk in r1866119. > > Merged to 2.4.x in r1866121. > > > > Thanks for this, Bill! > > > > > Am 29.08.2019 um 19:05 schrieb William A Rowe Jr <[email protected] > >: > > > > > > Index: httpd-2.x/CMakeLists.txt > > > =================================================================== > > > --- httpd-2.x/CMakeLists.txt (revision 1866089) > > > +++ httpd-2.x/CMakeLists.txt (working copy) > > > @@ -508,7 +508,9 @@ > > > modules/lua/lua_vmprep.c modules/lua/lua_dbd.c > > > ) > > > SET(mod_lua_requires LUA51_FOUND) > > > -SET(mod_md_requires OPENSSL_FOUND CURL_FOUND > JANSSON_FOUND HAVE_OPENSSL_102) > > > +# TODO: _requires does not currently iterate a list, substitute the > following once it does; > > > +# SET(mod_md_requires OPENSSL_FOUND CURL_FOUND > JANSSON_FOUND HAVE_OPENSSL_102) > > > +SET(mod_md_requires CURL_FOUND) > > > SET(mod_md_extra_includes ${OPENSSL_INCLUDE_DIR} > ${CURL_INCLUDE_DIR} ${JANSSON_INCLUDE_DIR}) > > > SET(mod_md_extra_libs ${OPENSSL_LIBRARIES} > ${CURL_LIBRARIES} ${JANSSON_LIBRARIES} mod_watchdog) > > > SET(mod_md_extra_sources > > > @@ -763,6 +765,7 @@ > > > ${CMAKE_CURRENT_SOURCE_DIR}/modules/session > > > ${CMAKE_CURRENT_SOURCE_DIR}/modules/ssl > > > ${CMAKE_CURRENT_SOURCE_DIR}/server > > > + ${CMAKE_CURRENT_SOURCE_DIR}/server/mpm/winnt > > > ${APR_INCLUDE_DIR} > > > ${PCRE_INCLUDE_DIR} > > > ) > > >
