Hi Bill,
Am 19.09.2019 um 19:39 schrieb William A Rowe Jr:
This commit somehow missed my inbox (and wasn't quoted in your observations)
http://svn.apache.org/viewvc?view=revision&revision=1864435
Rainer, you observed in the commit notes;
The GCC flag "-Wno-error=comment" introduced byr1855446
<http://svn.apache.org/viewvc?view=revision&revision=1855446>
andr1850745 <http://svn.apache.org/viewvc?view=revision&revision=1850745>
are only known since GCC 4.2. Since it gets
set unconditionally, this breaks compilation with old GCC
even when not using maintainer mode.
Make the fix for maintainer mode more specific by using
a version dependent pragma in the relevant two C files
only switching off error status for comment warnings.
Can we read this to say the comment error wasn't thrown by GCC 4.1 and
earlier?
I don't know. The flag was introduced in r1850745 plus r1855446 and
backported by r1856931. Jim's original commit log only mentions clang.
See PR63633 for more details about the problem caused by that change.
Can we please revert, and add an autoconf test for the support of (or lack
of errors against) this -Wno-error=comment flag? That should allow us to
apply it to all friendly compilers and avoid adding it to other elder
compilers.
I remember I tried that first and I am not sure what where the exact
problems I encountered, but I think we didn't have the configure/make
infrastructure in place to dynamically add CFLAGS for specific modules,
only LD flags.
Regards,
Rainer
On Thu, Sep 19, 2019 at 10:26 AM Jim Jagielski <j...@jagunet.com
<mailto:j...@jagunet.com>> wrote:
This breaks building on macOS:
Making all in filters
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -static -o libmod_data.la
<http://libmod_data.la> mod_data.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -static -o
libmod_ratelimit.la <http://libmod_ratelimit.la> mod_ratelimit.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -static -o
libmod_reqtimeout.la <http://libmod_reqtimeout.la> mod_reqtimeout.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -static -o
libmod_ext_filter.la <http://libmod_ext_filter.la> mod_ext_filter.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -static -o libmod_request.la
<http://libmod_request.la> mod_request.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -static -o libmod_include.la
<http://libmod_include.la> mod_include.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -static -o libmod_filter.la
<http://libmod_filter.la> mod_filter.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -static -o
libmod_reflector.la <http://libmod_reflector.la> mod_reflector.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -static -o
libmod_substitute.la <http://libmod_substitute.la> mod_substitute.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -static -o libmod_sed.la
<http://libmod_sed.la> mod_sed.lo sed0.lo sed1.lo regexp.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -static -o
libmod_charset_lite.la <http://libmod_charset_lite.la>
mod_charset_lite.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -static -o libmod_deflate.la
<http://libmod_deflate.la> mod_deflate.lo -L/usr/local/lib -lz
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=compile gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -DDARWIN
-DSIGPROCMASK_SETS_THREAD_MASK -DDARWIN_10 -DAP_DEBUG
-I/usr/local/include -I.
-I/Users/jim/src/asf/code/dev/httpd-trunk/os/unix
-I/Users/jim/src/asf/code/dev/httpd-trunk/include
-I/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/include
-I/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr-util/include
-I/usr/local/include
-I/Users/jim/src/asf/code/dev/httpd-trunk/modules/aaa
-I/Users/jim/src/asf/code/dev/httpd-trunk/modules/cache
-I/Users/jim/src/asf/code/dev/httpd-trunk/modules/core
-I/Users/jim/src/asf/code/dev/httpd-trunk/modules/database
-I/Users/jim/src/asf/code/dev/httpd-trunk/modules/filters
-I/Users/jim/src/asf/code/dev/httpd-trunk/modules/ldap
-I/Users/jim/src/asf/code/dev/httpd-trunk/server
-I/Users/jim/src/asf/code/dev/httpd-trunk/modules/loggers
-I/Users/jim/src/asf/code/dev/httpd-trunk/modules/lua
-I/Users/jim/src/asf/code/dev/httpd-trunk/modules/proxy
-I/Users/jim/src/asf/code/dev/httpd-trunk/modules/http2
-I/Users/jim/src/asf/code/dev/httpd-trunk/modules/session
-I/Users/jim/src/asf/code/dev/httpd-trunk/modules/ssl
-I/Users/jim/src/asf/code/dev/httpd-trunk/modules/test
-I/Users/jim/src/asf/code/dev/httpd-trunk/server
-I/Users/jim/src/asf/code/dev/httpd-trunk/modules/md
-I/Users/jim/src/asf/code/dev/httpd-trunk/modules/arch/unix
-I/Users/jim/src/asf/code/dev/httpd-trunk/modules/dav/main
-I/Users/jim/src/asf/code/dev/httpd-trunk/modules/generators
-I/Users/jim/src/asf/code/dev/httpd-trunk/modules/mappers
-prefer-non-pic -static -c mod_xml2enc.c -o mod_xml2enc.lo
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
/usr/local/include/unicode/ucnv.h:1:1: error: // comments are not
allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
/usr/local/include/libxml2/unicode/ucnv_err.h:1:1: error: //
comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
/usr/local/include/libxml2/unicode/utypes.h:1:1: error: // comments
are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:38:
/usr/local/include/libxml2/unicode/umachine.h:1:1: error: //
comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:38:
In file included from /usr/local/include/libxml2/unicode/umachine.h:46:
/usr/local/include/libxml2/unicode/ptypes.h:1:1: error: // comments
are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:38:
In file included from /usr/local/include/libxml2/unicode/umachine.h:46:
In file included from /usr/local/include/libxml2/unicode/ptypes.h:52:
/usr/local/include/libxml2/unicode/platform.h:1:1: error: //
comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:38:
In file included from /usr/local/include/libxml2/unicode/umachine.h:46:
In file included from /usr/local/include/libxml2/unicode/ptypes.h:52:
In file included from /usr/local/include/libxml2/unicode/platform.h:24:
/usr/local/include/libxml2/unicode/uconfig.h:1:1: error: // comments
are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:38:
In file included from /usr/local/include/libxml2/unicode/umachine.h:46:
In file included from /usr/local/include/libxml2/unicode/ptypes.h:52:
In file included from /usr/local/include/libxml2/unicode/platform.h:25:
/usr/local/include/libxml2/unicode/uvernum.h:1:1: error: // comments
are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:38:
In file included from /usr/local/include/libxml2/unicode/umachine.h:379:
/usr/local/include/libxml2/unicode/urename.h:1:1: error: // comments
are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:39:
/usr/local/include/libxml2/unicode/uversion.h:1:1: error: //
comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:44:
/usr/local/include/libxml2/unicode/utf.h:1:1: error: // comments are
not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:44:
In file included from /usr/local/include/libxml2/unicode/utf.h:217:
/usr/local/include/libxml2/unicode/utf8.h:1:1: error: // comments
are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:44:
In file included from /usr/local/include/libxml2/unicode/utf.h:218:
/usr/local/include/libxml2/unicode/utf16.h:1:1: error: // comments
are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:44:
In file included from /usr/local/include/libxml2/unicode/utf.h:221:
/usr/local/include/libxml2/unicode/utf_old.h:1:1: error: // comments
are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:44:
In file included from /usr/local/include/libxml2/unicode/utf.h:221:
In file included from /usr/local/include/libxml2/unicode/utf_old.h:150:
/usr/local/include/libxml2/unicode/utf.h:1:1: error: // comments are
not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:53:
/usr/local/include/libxml2/unicode/uenum.h:1:1: error: // comments
are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:53:
In file included from /usr/local/include/libxml2/unicode/uenum.h:23:
/usr/local/include/libxml2/unicode/localpointer.h:1:1: error: //
comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
17 errors generated.
make[3]: *** [mod_xml2enc.lo] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all-recursive] Error 1
