The patch looks nice. Running it in my test suite over and over without any crash showing up!
Great work! > Am 25.09.2019 um 13:24 schrieb Yann Ylavic <ylavic....@gmail.com>: > > On Wed, Sep 25, 2019 at 11:54 AM Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >> >> Looking for help on an issue in mod_watchdog use and child exits. >> >> Occasionally a httpd child crashes due to races between child pool being >> destroyed while watchdog threads are still running. The crash manifests most >> likely when OPENSSL_cleanup runs while another thread is generated a private >> key (singe that takes relatively long). >> >> Beside the crash report, nothing else really fails since the child is >> terminating anyway and no requests are onoing. But still, it's not a nice >> thing. >> >> Do you see an easy way to avoid this? > > AFAICT, clean_child_exit() destroys pchild only, and pconf is still > alive at exit() time. > Couldn't we use pconf only in child_init hooks of mod_ssl and mod_watchdog? > Does something like the attached patch fixes the crash? > <some_pchild_to_pconf.diff>
