On Wed, Nov 6, 2019 at 6:54 PM Joe Orton <jor...@redhat.com> wrote: > > Has anybody seen t/modules/deflate.t and t/modules/brotli.t fail on > Debian-ish distro? I don't remember seeing this before but maybe it's > something > trivial? t/TEST output -
It seems to originate from r1868312. I don't really understand this new test in mod_deflate (the one which fails): ok $original_str eq $deflated_str_q0; Why would we expect a plain string to be equal to a deflated one, Christophe? I don't see how the failure depends on debian vs any other system either. Running t/modules/deflate.t on my debian, with this debugging patch: ``` Index: t/modules/deflate.t =================================================================== --- t/modules/deflate.t (revision 1869498) +++ t/modules/deflate.t (working copy) @@ -57,6 +57,10 @@ for my $server_deflate_uri (@server_deflate_uris) ok $original_str eq $inflated_str; ok $original_str eq $deflated_str_q0; + if (not $original_str eq $deflated_str_q0) { + print "original: '$original_str'\n"; + print "deflated: '$deflated_str_q0'\n"; + } my $resp = POST($server_inflate_uri, @inflate_headers, content => "foo123456789012346"); if (have_min_apache_version("2.5")) { ``` I get (e.g.): ``` not ok 42 original: ' Some dummy content. Some dummy content. Some dummy content. Some dummy content. EOF ' deflated: '<some binary (gziped) stuff, expected I guess>' # Failed test 42 in t/modules/deflate.t at line 59 fail #11 ``` Am I missing something? Regards, Yann.