It reads ok, I think there could be other cases later in the code where X509_free(issuer) should be called (after if(cinf) IMHO).
Giovanni On 4/7/20 9:36 AM, Stefan Eissing wrote: > Oops. Reading my merged change, I see that we do not free the "X590 *issuer" > from line 134, ssl_util_stapling.c when stapling is not active. Can anyone > confirm my read? Then I'd make a patch to attach to the PR. > > ~icing > >> Anfang der weitergeleiteten Nachricht: >> >> *Von: *bugzi...@apache.org <mailto:bugzi...@apache.org> >> *Betreff: **[Bug 63687] High Memory usage after upgrade to 2.4.41* >> *Datum: *6. April 2020 um 18:01:27 MESZ >> *An: *b...@httpd.apache.org <mailto:b...@httpd.apache.org> >> *Antwort an: *"Apache HTTPD Bugs Notification List" <b...@httpd.apache.org >> <mailto:b...@httpd.apache.org>> >> >> https://bz.apache.org/bugzilla/show_bug.cgi?id=63687 >> >> --- Comment #81 from Curtis Wilson <curtis.wil...@endurance.com> --- >> So after determining the trigger for causing this to happen (Reloads) we were >> able to track this down to a specific commit that was causing this issues, >> and >> building a build without this commit and installing it to test servers we did >> find that without this commit the memory issues that have been happening no >> longer are occuring. >> >> >> >> $ git bisect good >> 734313ca6e758f94ae3f923f801f34da02251b9b is the first bad commit >> commit 734313ca6e758f94ae3f923f801f34da02251b9b >> Author: Stefan Eissing <ic...@apache.org> >> Date: Tue Jul 30 11:23:52 2019 +0000 >> >> Merged /httpd/httpd/trunk:r1851621,1852128,1862075 >> >> *) mod_ssl/mod_md: reversing dependency by letting mod_ssl offer hooks >> for >> adding certificates and keys to a virtual host. An additional hook >> allows >> answering special TLS connections as used in ACME challenges. >> Adding 2 new hooks for init/get of OCSP stapling status information >> when >> other modules want to provide those. Falls back to own implementation >> with >> same behaviour as before. >> >> >> >> git-svn-id: >> https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1863988 >> 13f79535-47bb-0310-9956-ffa450edef68 >> >> CHANGES | 8 +++ >> modules/ssl/mod_ssl.h | 29 ++++++++++ >> modules/ssl/mod_ssl_openssl.h | 40 ++++++++++++++ >> modules/ssl/ssl_engine_init.c | 116 >> +++++++++++++++++----------------------- >> modules/ssl/ssl_engine_kernel.c | 74 +++++++++++++++++-------- >> modules/ssl/ssl_util_stapling.c | 93 +++++++++++++++++++++++++------- >> 6 files changed, 253 insertions(+), 107 deletions(-) >> >> -- >> You are receiving this mail because: >> You are the assignee for the bug. >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org >> For additional commands, e-mail: bugs-h...@httpd.apache.org >> >
