On Mon, Apr 20, 2020 at 8:51 AM Ruediger Pluem:
>
> On 4/19/20 5:26 PM, Yann Ylavic wrote:
> > +
> > + /* Validate Host/Expect headers and select vhost. */
> > if (!ap_check_request_header(r)) {
> > access_status = r->status;
> > - goto die_early;
> > + goto die_before_hooks;
> > }
>
> Shouldn't we ensure that
>
> r->per_dir_config = r->server->lookup_defaults;
>
> is done before we jump to die_before_hooks ?
Yes, correct, ap_check_request_header() can fail for (e.g.) invalid
Expect header, in which case r->server may still have changed.
>
> Otherwise I think looks good. As said my biggest worry was that we do not use
> vhost specific ErrorDocuments in cases where we used
> them.
Thanks for the review, hopefully everything addressed in r1876784.
Regards,
Yann.
