Re: svn commit: r1877954 - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/apreq/ modules/cache/ modules/dav/main/ modules/filters/ modules/http/ modules/mappers/ modules/proxy/ server/

Wed, 20 May 2020 11:53:09 -0700 


On 5/20/20 5:58 PM, Yann Ylavic wrote:
> On Wed, May 20, 2020 at 4:44 PM Ruediger Pluem <rpl...@apache.org> wrote:
>>
>>> +    return (!r->header_only
>>> +            && (r->kept_body
>>> +                || apr_table_get(r->headers_in, "Transfer-Encoding")
>>> +                || ((cls = apr_table_get(r->headers_in, "Content-Length"))
>>> +                    && ap_parse_strict_length(&cl, cls) && cl > 0)));
>>
>> Are we sure that cls is not NULL here? ap_parse_strict_length is not NULL 
>> safe :-)
> 
> Hmm, I suppose that if cls is NULL the next "&& ap_parse.." is not evaluated 
> :)

My bad :-p. cls = apr_table_get(r->headers_in, "Content-Length") already does 
that NULL check already.
All good.

Regards

Rüdiger






















					Reply via email to