Agreed - thank you (everyone) for the quick rally to fix this and for confirming we don't have other work needing to be done. I apologize for taking almost 24 hours to ACK and get us moving again.
I've updated CHANGES and will send a VOTE shortly -- Daniel Ruggeri On 7/31/2020 1:28 PM, Rainer Jung wrote: > Since here were lots of "good-to-go, let's roll" one note though: the > current CHANGES does not yet a section for 2.4.46, cause normally > APLOGNO doesn't get noted on CHANGES. In this case it might be > something like > > *) mod_proxy_fcgi: Fix build on Windows. > > and credits for Eric (who fixed it on trunk) oand/or Christophe, who > backported it. > > Best regards, > > Rainer > > Am 31.07.2020 um 15:36 schrieb Rainer Jung: >> Since there wasn't yet any reaction to Daniel's question: Is anybody >> right now working on more warnings fixes for Windows? >> >> The most prominent one (missing APLOGNo number = missing macro >> argument) IMHO was already fixed by Christophe in r1880438. Anything >> else worth waiting for or are we (is Daniel) good to go for 2.4.46? >> >> Concerning lua I'd say the fix(es) for 5.4.0 need a bit more testing. >> >> Regards, >> >> Rainer >> >> Am 30.07.2020 um 22:26 schrieb Daniel Ruggeri: >>> Hi, all; >>> I thank everyone for their testing and quick feedback. While we had >>> enough votes and positive feedback, we have some easily fixable >>> warnings >>> which have precedence for holding up a release. >>> >>> To that end, I will close this vote and declare 2.4.45 dead on >>> the vine. >>> >>> I will roll 2.4.46 when we are all buttoned up with the warnings.