On Fri, Dec 11, 2020 at 3:04 PM Joe Orton <jor...@redhat.com> wrote: > > On Fri, Dec 11, 2020 at 01:48:39PM +0100, Yann Ylavic wrote: > > On Fri, Dec 11, 2020 at 12:59 PM Ruediger Pluem <rpl...@apache.org> wrote: > > > > > > On 12/11/20 12:30 PM, Travis CI wrote: > > > > > > > > branch icon2.4.x <https://github.com/apache/httpd/tree/2.4.x> > > > > > > > > build has failed > > > > > > I think this is exposed by r1883752 > > > (http://svn.apache.org/viewvc?view=revision&revision=1883752), > > > > The old code would also have abort()ed on a NULL pool. > > > > > but the real root cause is the > > > missing backport of r1876626 > > > (http://svn.apache.org/viewvc?view=revision&revision=1876626) to 2.4.x. > > > Thoughts? > > > > Good catch! +1 for backport. > > +1 from me too, can we get a third?
Those: *) core: reset ap_runtime_dir to NULL after AP_SQ_MS_DESTROY_CONFIG. *) mod_http2: stop/wait the workers threads before their pool is killed. in STATUS already are also about making the ci pass on 2.4.x with the same set as trunk. +1s are welcome (and easy I think) there too :) Regards; Yann.
