On Wed, Aug 25, 2021 at 9:53 AM Ruediger Pluem <rpl...@apache.org> wrote:
>
> On 8/25/21 12:22 AM, yla...@apache.org wrote:
>
> > @@ -3753,16 +3761,13 @@ static int event_pre_config(apr_pool_t *
> > if (!retained) {
> > retained = ap_retained_data_create(userdata_key,
> > sizeof(*retained));
> > retained->mpm = ap_unixd_mpm_get_retained_data();
> > + retained->mpm->baton = retained;
> > retained->max_daemons_limit = -1;
> > if (retained->mpm->module_loads) {
> > test_atomics = 1;
> > }
> > }
> > retained->mpm->mpm_state = AP_MPMQ_STARTING;
> > - if (retained->mpm->baton != retained) {
> > - retained->mpm->was_graceful = 0;
>
> Why is this no longer needed?
Argh, forgot to revert this change, first because it's unrelated and
second because it's bad.
I first thought that the ->baton never changes (forgot why I did that
in the first place) but if a different MPM is LoadModule'd during
restart it does, and we want to be ungraceful..
Thanks for noticing, I'll revert.
Regards;
Yann.
