> Am 25.08.2021 um 15:30 schrieb Joe Orton <jor...@redhat.com>:
>
> On Mon, Aug 23, 2021 at 03:03:34PM +0200, ste...@eissing.org wrote:
>>
>>
>>> Am 23.08.2021 um 14:40 schrieb Joe Orton <jor...@redhat.com>:
>>>
>>> On Mon, Aug 23, 2021 at 12:59:19PM +0200, ste...@eissing.org wrote:
>>>> The http2 test suites in https://github.com/icing/mod_h2 and svn trunk are
>>>> now nearly identical. I made some small adjustment and also have them
>>>> running in debian sid and archlinux docker images (make docker-test in
>>>> the github repro).
>>>
>>> It works on my machine with r1892545, which I hope does not break things
>>> on your machine(s)?
>>
>> Nice! Don't see a problem with that change.
>>
>>> Started an attempt at getting Travis working here:
>>> https://github.com/apache/httpd/pull/262
>>>
>>> ... but it's quite likely to need some tweaks to the installed package
>>> set to get working at minimum.
>>
>>
>> In my Dockerfiles on https://github.com/icing/mod_h2/tree/master/docker I
>> install everything (plus the apach2 package). Maybe that helps.
>
> I'm not sure whether all the packages in that are really needed, e.g.
> tqdm and pycurl?
>
No, I use tqdm in my load scenarios, not needed to the test suite itself.
> This is as far as I got so far in Travis:
>
> https://app.travis-ci.com/github/apache/httpd/builds/236173863#L2985
This looks like the recent "reload" optimization, as I see similar failures now
on my machine.
> Any idea what causes those failures?
>
> There is just one change to test/modules/http2 which I haven't pushed to
> trunk, is this OK?
>
> https://github.com/notroj/httpd/commit/72a037003cae0c8c634313d0707311222fe237e0
Looks fine.
>
> Regards, Joe
>
>
>>
>> - Stefan
>>
>>>
>>> Regards, Joe
>>>
>>>
>>>>
>>>> Cheers, Stefan
>>>>
>>>>> Am 20.08.2021 um 18:08 schrieb ste...@eissing.org:
>>>>>
>>>>> Done in r1892476. Looking forward on how this works on your machines.
>>>>>
>>>>> - Stefan
>>>>>
>>>>>> Am 20.08.2021 um 13:50 schrieb ste...@eissing.org:
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Am 20.08.2021 um 13:46 schrieb Joe Orton <jor...@redhat.com>:
>>>>>>>
>>>>>>> On Fri, Aug 20, 2021 at 11:35:45AM +0200, Stefan Eissing wrote:
>>>>>>>> https://github.com/apache/httpd/pull/260
>>>>>>>> a PR with the http2 test suite in trunk/test/modules/http2
>>>>>>>>
>>>>>>>> How to use:
>>>>>>>>
>>>>>>>> • run configure again after you checked this out
>>>>>>>> • the following components need to be installed on your system:
>>>>>>>> • python3, pytest
>>>>>>>> • curl, nghttp, h2load
>>>>>>>>
>>>>>>>> run the tests:
>>>>>>>>> make install
>>>>>>>>> cd test
>>>>>>>>> pytest
>>>>>>>
>>>>>>> Awesome!
>>>>>>
>>>>>> Thanks!
>>>>>>
>>>>>>>> This starts the installed httpd on local ports
>>>>>>>> 40001 + 40002, runs the test suite and tears it down again.
>>>>>>>> To run individual test cases, use
>>>>>>>>
>>>>>>>>> cd test/modules/http2
>>>>>>>>> pytest -k test_004 # run all tests in test_004_post.py
>>>>>>>>> pytest -k test_004_07 # run test 07 in test_004_post.py
>>>>>>>>
>>>>>>>> Next would be the definition to run this in a Docker file via
>>>>>>>> Travis. If someone familiar with that setup could help me to
>>>>>>>> start this?
>>>>>>>
>>>>>>> Does this need to run in Docker, or can it run directly in a Linux vm?
>>>>>>
>>>>>> For me, it runs directly on MacOS and I believe it should also on any
>>>>>> linux
>>>>>> with the prerequisites installed.
>>>>>>
>>>>>>> It would make sense to me to add separate job in Travis for this which
>>>>>>> has the right Debian packages installed, and adjust test/travis*.sh to
>>>>>>> make run the tests in a similar way to how TEST_SSL etc work.
>>>>>>
>>>>>> That is probably a good start. When this works reliably, we may add
>>>>>> a flag to the common linux script to run it. The additional packages
>>>>>> should not be really a burden for docker, I believe.
>>>>>>
>>>>>>>> PS. I made a PR to not disturb our existing travis setup, but if
>>>>>>>> trunk is the better place to refine this, just say so.
>>>>>>>
>>>>>>> FWIW I'd say this is mostly personal preference, unless you expect to
>>>>>>> break trunk and hold up others working there, it's always fine to work
>>>>>>> on trunk. You get the cost/benefit of Travis for your changes either
>>>>>>> way.
>>>>>>
>>>>>> Ok, will merge it to trunk later today or quite soon.
>>>>>>
>>>>>>>
>>>>>>> Regards, Joe
