On Mon, Feb 7, 2022 at 12:41 PM Yann Ylavic <ylavic....@gmail.com> wrote:
>
> On Tue, Jan 25, 2022 at 1:12 PM Stefan Eissing <ste...@eissing.org> wrote:
> >
> > Also, while running the http2 test suite, I get repeated assert failures in
> > event.c:1230
> >
> > if (rv != APR_SUCCESS && !APR_STATUS_IS_EEXIST(rv)) {
> > -> AP_DEBUG_ASSERT(0);
> > TO_QUEUE_REMOVE(cs->sc->wc_q, cs);
> > apr_thread_mutex_unlock(timeout_mutex);
> > ap_log_error(APLOG_MARK, APLOG_ERR, rv, ap_server_conf, APLOGNO(03465)
> > "process_socket: apr_pollset_add failure for "
> > "write completion");
> > close_connection(cs);
> > signal_threads(ST_GRACEFUL);
> > }
> >
> > Seems something is fishy with the recent changes.
>
>
> The assertion failure is due to mpm_event closing all the workers'
> sockets forcibly [1] on ungraceful shutdown/restart, while the socket
> is still handled by h2, thus when h2 gives the connection back to the
> mpm fr lingering close it fails.
>
> This is fixed in PR #294 by [2].
>
> [1]
> https://github.com/apache/httpd/pull/294/files#diff-0f7c762a65575c89143d8ab894ec9d79e6f2f26aca2c4e4c102e129043683310L594
> [2]
> https://github.com/apache/httpd/pull/294/files#diff-0f7c762a65575c89143d8ab894ec9d79e6f2f26aca2c4e4c102e129043683310R1143
With the right links..
[1]
https://github.com/apache/httpd/pull/294/commits/9996178dfdb01d41ae26a196109241e16cc041a6#diff-0f7c762a65575c89143d8ab894ec9d79e6f2f26aca2c4e4c102e129043683310L597
[2]
https://github.com/apache/httpd/pull/294/commits/9996178dfdb01d41ae26a196109241e16cc041a6#diff-0f7c762a65575c89143d8ab894ec9d79e6f2f26aca2c4e4c102e129043683310R1070
>
> Regards;
> Yann.
