On 3/9/22 11:34 AM, Rainer Jung wrote:
> Am 09.03.2022 um 08:37 schrieb Ruediger Pluem:
>>
>>
>> On 3/8/22 10:09 PM, Rainer Jung wrote:
>>>
>>
>>>
>>> You gcc 4.8 workaround for _Thread_local still looks good.
>>>
>>> Solaris builds and all unit tests not yet done but compiles fine for all my
>>> Linuxes.
>>>
>>> Thanks!
>>
>> Thanks for testing. I committed to trunk as r1898771 to throw it into our
>> CI. If we need to tweak it further we can do later.
>>
>> BTW: Once we have a final patch the same needs to be done for APR trunk and
>> APR 1.8.x.
>
> Interesting: I did also compile APR trunk in my httpd release preparations
> but didn't observe the failure. This probably was due
> to the fact, that our APR trunk configure does not decide to add -std=gnu11,
> so the test in the header file doesn't result in
> _Thread_local being used.
>
> Of course it still makes sense to apply the same patch (and also to other APR
> branches containing the thread local code). Just
> wondering, whether the different handling of the"std" compiler flag for httpd
> and apr trunk is intentional.
>
Weird. I don't see -std=gnu11 added at all to my httpd build on RedHat 8.
gcc --version
gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-4)
autoconf --version
autoconf (GNU Autoconf) 2.69
But I have tested the patch and get AP_THREAD_LOCAL set to _Thread_local as it
should.
Regards
Rüdiger
