On 6/9/23 6:28 PM, jean-frederic clere wrote:
> On 6/9/23 14:58, rpl...@apache.org wrote:
>> Author: rpluem
>> Date: Fri Jun 9 12:58:55 2023
>> New Revision: 1910327
>>
>> URL: http://svn.apache.org/viewvc?rev=1910327&view=rev
>> Log:
>> * Vote and comment [skip ci]
>>
>> Modified:
>> httpd/httpd/branches/2.4.x/STATUS
>>
>> Modified: httpd/httpd/branches/2.4.x/STATUS
>> URL:
>> http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1910327&r1=1910326&r2=1910327&view=diff
>> ==============================================================================
>> --- httpd/httpd/branches/2.4.x/STATUS (original)
>> +++ httpd/httpd/branches/2.4.x/STATUS Fri Jun 9 12:58:55 2023
>> @@ -213,6 +213,7 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
>> Backport version for 2.4.x of patch:
>>
>> https://raw.githubusercontent.com/jfclere/patch/main/mod_deflate.patch
>> +1: jfclere,
>> + rpluem says: Does anyone know why we don't merge the server config?
>
> We have:
> +++
> create_deflate_dirconf, /* dir config creater */
> NULL, /* dir merger --- default is to override */
> create_deflate_server_config, /* server config */
> NULL, /* merge server config */
> +++
>
> Are you asking why? ;-)
Exactly. I know that your patch only follows the existing pattern, but it came
to my attention when reviewing
it and I asked myself why we don't merge here. Hence the question is not really
specifically to you but to
everyone. Having a brief look into the version history reveals that it has been
like that since the module exists.
Hence I am not sure if anyone can provide a historical reasoning here. But
probably we think together if this is
the behavior we want to keep for some reason or if we should change it.
Regards
Rüdiger
