On Wed, Jun 19, 2024 at 2:52 PM Joe Orton <jor...@redhat.com> wrote: > > On Wed, Jun 19, 2024 at 02:04:20PM +0200, Yann Ylavic wrote: > > On Wed, Jun 19, 2024 at 1:00 PM Ruediger Pluem <rpl...@apache.org> wrote: > > > As far as I read the code it does not. > > > > > > https://github.com/apache/apr/blob/b0a08c76ceacc2308d7cf1d5a7bb3c9b4665a432/network_io/unix/sockets.c#L423-L433 > > > > > > We copy the data (sa, salen family and port) not a pointer. > > > > Ah yes, I was looking at win32 code, while Joe fixed it 13 years ago > > for unix (r983618). > > So the pointer copy exists, but only for WIN32 and OS/2 AFAICT, what a mess. > > Sorry!
How so, that's a fix :) > > > Let me fix that then ;) > > There is a test in that commit, is it not catching the bug on non-Unix? > > BTW can you add r1918228 to your backport proposal, the debug output is > corrupted for this code otherwise. Done in PR 454, will update STATUS too. Regards; Yann.
