On Wed, Jun 26, 2024 at 10:28 AM Ruediger Pluem <rpl...@apache.org> wrote:
>
> On 3/19/23 10:30 PM, yla...@apache.org wrote:
> >
> > --- httpd/httpd/trunk/modules/ssl/ssl_engine_io.c (original)
> > +++ httpd/httpd/trunk/modules/ssl/ssl_engine_io.c Sun Mar 19 21:30:47 2023
>
> > @@ -2402,7 +2403,7 @@ long ssl_io_data_cb(BIO *bio, int cmd,
> > "%s: %s %ld/%d bytes %s BIO#%pp [mem: %pp] %s",
> > MODSSL_LIBRARY_NAME,
> > (cmd == (BIO_CB_WRITE|BIO_CB_RETURN) ? "write" :
> > "read"),
> > - rc, argi, (cmd == (BIO_CB_WRITE|BIO_CB_RETURN) ? "to"
> > : "from"),
> > + (long)rc, argi, (cmd == (BIO_CB_WRITE|BIO_CB_RETURN) ?
> > "to" : "from"),
>
> I think rc has a different meaning with OpenSSL 3. I think we need to use len
> in case of OpenSSL 3.
> I noticed that with OpenSSL 3 only single bytes get dumped and no longer the
> whole buffer.
>
> > bio, argp, dump);
> > if (*dump != '\0' && argp != NULL)
> > ssl_io_data_dump(c, s, argp, rc);
>
> Similar to above. I think we need to use len here in case of OpenSSL 3.
> If my findings are seen as correct I could work on a patch :-).
I think you are right from the man page of BIO_set_callback{,_ex}(),
please go ahead ;)
Regards;
Yann.
