On Fri, Jul 5, 2024 at 5:08 PM Ruediger Pluem <rpl...@apache.org> wrote: > > On 7/5/24 4:09 PM, Stefan Eissing via dev wrote: > > > > > >> Am 05.07.2024 um 15:44 schrieb Ruediger Pluem <rpl...@apache.org>: > >> > >> > >> > >> On 7/5/24 3:40 PM, Yann Ylavic wrote: > >>> On Fri, Jul 5, 2024 at 3:35 PM Yann Ylavic <ylavic....@gmail.com> wrote: > >>>> > >>>> On Fri, Jul 5, 2024 at 3:05 PM Ruediger Pluem <rpl...@apache.org> wrote: > >>>>> > >>>>>>>>> md_crypt.c: In function 'md_cert_get_ct_scts': > >>>>>>>>> md_crypt.c:2071:5: error: unknown type name 'SCT' > >>>>>>>>> SCT *sct_handle; > >>>>> > >>>>> This one is caused by r1918195 in >= 2.4.60. Before r1918195 > >>>>> OPENSSL_NO_CT was defined when openssl was < 1.1.1. Now it is not any > >>>>> longer and hence md_cert_get_ct_scts gets a real function body as > >>>>> > >>>>> #ifndef OPENSSL_NO_CT > >>>>> > >>>>> (line 2068) is now true. Hence we error out on the non presence of the > >>>>> SCT struct (line 2071). > >>>> > >>>> Maybe something like the attached patch for this one too (which could > >>>> avoid configure tricks for both..). > >>> > >>> Or rather this one. > >>> > >> > >> > >> Looks good to me. Waiting for Stefan's feedback. > > > > The patches look good to me. I have not tested them as I have no old > > openssl lying around, but I trust in your build tests. > > Rebuild 2.4.61 with both patches from Yann on RedHat 7 - 9. All good now, > even on 7 with openssl 1.0.2 (means it compiles and no > more implicit declaration warnings). > @Yann: Care to commit the patches?
Will do on the weekend if/when possible, feel free to beat me to it if you can ;) Regards; Yann.
