Hi all,

If anyone has a little time to spare, I would really appreciate a review of the 
proposed SetEnvFromFile backport to 2.4.x:

https://github.com/apache/httpd/pull/934

The directive loads internal environment variables from a file at configuration 
time. The backport includes the trunk implementation, along with the read-error 
handling and quoted-value fixes merged in 
apache/httpd#1004<https://github.com/apache/httpd/pull/1004>.

All 36 upstream CI checks are passing, and local validation against 2.4.72-dev 
also passed all 72 directive regression cases.

No rush, of course. Any feedback or suggestions would be very welcome.

Many thanks for your time and help!

Cornel

________________________________
From: Joe Orton <[email protected]>
Date: Friday, 18 September 2026 at 14:23
To: [email protected] <[email protected]>
Subject: Re: [PROPOSAL] mod_env: new SetEnvFromFile directive (PR #750)

EXTERNAL: Use caution when clicking on links or opening attachments.


On Fri, Sep 18, 2026 at 08:16:24AM +0000, Cornel Isbiceanu via dev wrote:
> Hi all,
>
> Thank you for taking the time to look at this. I've applied all the
> changes I had in mind and rebased the branch so it merges cleanly
> against trunk. The PR is here:
>
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhttpd%2Fpull%2F750%2Fchanges&data=05%7C02%7Ccisbiceanu%40adobe.com%7C65a305e15ee84b24c55308df15774eee%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C639253274322155933%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=6YmNxo%2B3huKyh1QynOZp%2BBiXtHWJGoSKx3%2FAinYu%2BpA%3D&reserved=0<https://github.com/apache/httpd/pull/750/changes>
>
> I'm very much open to any further changes — whether that's naming, the
> directive's allowed context, the way the file is parsed, security
> considerations, tests, or anything else the reviewers feel would make
> it a better fit for httpd. Happy to iterate as much as needed; I'd
> rather get it right than get it in.

Thanks for redoing it. Makes sense to me to restrict the directive like
this. Does anybody else have any feedback/concerns here now?

> One small thing: I haven't seen any CI checks run on the PR yet.

Unfortunately due to the way our SVN->Git mirror is set up, we are not
able to approve CI runs for non-committers. If you enable Actions in
your fork it should run there, and I think the results becomes visible
in the apache/httpd PR as well (not sure about that, but at least you
could point to them). The fact you've added test cases which we can
verify is more than sufficient in any case.

Regards, Joe

Reply via email to