+1 This is also documented here already https://hudi.apache.org/contributing.html#lifecycle This one was an oversight from me, since I was mulling if this completely fixes 159 or not. Thanks for catching! We have not gotten around to automating this as a commitlint
On Mon, Jul 15, 2019 at 4:28 PM Manu Zhang <owenzhang1...@gmail.com> wrote: > Linking the jira issue id in the PR/commit will help to avoid duplicating > work. I think it's good to enforce this rule as a GitHub PR template. > > Thanks, > Manu > > On Tue, Jul 16, 2019 at 3:13 AM Vinoth Chandar <vin...@apache.org> wrote: > > > Thanks for confirming. > https://github.com/apache/incubator-hudi/pull/751 > > passed the demo and few others tests. > > > > Late Friday, also had a chat with the author of > > https://github.com/apache/incubator-hudi/pull/780 to rework that based > off > > this PR. > > > > > > > > On Thu, Jul 11, 2019 at 11:32 PM Bhavani Sudha Saktheeswaran > > <bhasu...@uber.com.invalid> wrote: > > > > > I was able to successfully test few Presto queries in the staging > > > environment. Looks good to me. > > > > > > Thanks, > > > Sudha > > > > > >
