Partially agree on the first one. For some classes say HoodieTableFileSystemView, it is redundant.. That said, most IDEs index by class names and having the prefix does help at times to quickly switch classes IMO On the second, its not just classes.. the configs need to be renamed and say the arguments to delta streamer. I definitely suggest not changing this for now, to reduce the number of things a user has to do to migrate to asf release. Even longer term, I still feel there is diminishing returns from this. Even today, external citations etc is very consistent with Hudi.
On Tue, Aug 13, 2019 at 11:14 PM vino yang <yanghua1...@gmail.com> wrote: > Hi vinm, > > About the name of classes, My thought is: > > - IMO, we can reduce the "Hoodie" or "Hudi" prefix for many classes, > e.g. classes under package org.apache.hudi.common.model, the prefix's > main > purpose is to distinguish with other classes comes from the third-party > library in the same module or package. Since this is hudi project, > peoples > know those classes belong hudi, in the referenced module we can also > identify them by the package name. In this case, the prefix may not be > necessary, and make the length of the classes name too long. > - It would be better to keep one keywork: Hudi in the whole project. The > consistency of the name can make the newbie more clear. And it allows > us to > be consistent in publicity and citation. > > What do you think? > > Best, > Vino > > Vinoth Chandar <vin...@apache.org> 于2019年8月13日周二 下午11:33写道： > > > Thanks! Def glad to get this done. Credits should go to balaji :) > > > > My 2c is that its okay for classes to remain how they are. There is > > diminishing returns to do that and “Hoodie” is the suggested > pronunciation > > :) anyway. > > > > On Sun, Aug 11, 2019 at 6:23 PM vino yang <yanghua1...@gmail.com> wrote: > > > > > Hi Vinoth, > > > > > > Thanks for your effort! Good job! > > > > > > Another question that maybe not related to this thread: Shall we > replace > > > all the keyword "Hoodie" to "Hudi"? > > > > > > What do you think? > > > > > > Best, > > > Vino > > > > > > Vinoth Chandar <vin...@apache.org> 于2019年8月12日周一 上午8:51写道： > > > > > > > This has landed on master. Please rebase your PRs as needed. > > > > Some tips here https://issues.apache.org/jira/browse/HUDI-165 > > > > > > > > On Fri, Aug 9, 2019 at 8:56 AM Vinoth Chandar <vin...@apache.org> > > wrote: > > > > > > > > > PSA: https://github.com/apache/incubator-hudi/pull/830 is up . > > Please > > > > > provide feedback > > > > > > > > > > On Wed, Aug 7, 2019 at 1:40 PM Luciano Resende < > luckbr1...@gmail.com > > > > > > > > wrote: > > > > > > > > > >> On Wed, Aug 7, 2019 at 1:34 PM nishith agarwal < > n3.nas...@gmail.com > > > > > > > >> wrote: > > > > >> > > > > > >> > +1 > > > > >> > > > > > >> > Efforts are already under way for package renaming but has to be > > > done > > > > >> > carefully to avoid repeated work and conflicts. Balaji is taking > > > care > > > > of > > > > >> > this I believe. > > > > >> > > > > > >> > - Nishith > > > > >> > > > > > >> > > > > >> As long as the package renaming is being taken care, then it's ok > to > > > > >> new modules go either way. > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> -- > > > > >> Luciano Resende > > > > >> http://twitter.com/lresende1975 > > > > >> http://lresende.blogspot.com/ > > > > >> > > > > > > > > > > > > > > >
