+1 (non-binding) - checkout source code & run "mvn clean package" [OK] - run "mvn test" under hudi-client module[OK] - checked release note[OK] - checked signatures[OK]
IMO, before the next release, we may need to check the consistency of multilingual documents. Best, Vino [email protected] <[email protected]> 于2019年10月10日周四 下午1:06写道： > > Thanks everyone. The voting has concluded. > We had 7 +1 votes out of which 3 are binding > > - leesf > - Gurudatt Kulkarni > - Bhavani Sudha Saktheeswaran > - Nishith Agarwal (Binding) > - Vinoth Chandar (Binding) > - Prasanna Rajaperumal (Binding) > - Udit Mehrotra > > There was one -0 vote from Thomas Weise. He has pointed out the missing > "incubating" keyword in NOTICE file but also noted that this inconsistency > is seen in other incubating projects. This inconsistency has been fixed in > master now ( > https://github.com/apache/incubator-hudi/commit/834c591955cfa8a9c5f286967d693932564b6764 > ). > The vote has passed. Thanks everyone > Regards,Balaji.V > > On Wednesday, October 9, 2019, 05:05:48 PM PDT, [email protected] < > [email protected]> wrote: > > > Thanks Thomas. It looks like data-sketches team will be fixing the NOTICE > file in master. We will also fix this in master. Also other incubating > projects (incubator-gobblin) which have released earlier have similar > NOTICE format (no "incubating"). > I will wait for couple of hours to see if there are any replies to your > email in general@incubator. If not, I am inclined to moving forward with > voting to general@. If this inconsistency turns out to be show-stopper, > having a failed vote in general@ would give us an opportunity to collect > more feedback comment. This will help us reduce the overall turnaround time > in releasing the first version. > > Thanks,Balaji.V > On Wednesday, October 9, 2019, 10:05:22 AM PDT, Thomas Weise < > [email protected]> wrote: > > FYI there is inconsistency regarding "(incubating)" in the NOTICE file > between other projects I looked at. I asked the question on another release > VOTE on general@ > > I would recommend to make the change anyways, but depending on what > feedback there is regarding the above, can still consider move forward with > this RC (that's why -0) > > On Wed, Oct 9, 2019 at 9:55 AM Thomas Weise <[email protected]> wrote: > > > -0 (binding) > > > > NOTICE needs to include "(incubating)" > > > > Minor: VOTE refers to "The official Apache source release and binary > > convenience releases" but there is no binary release. > > > > Otherwise things look good. > > > > Signature check PASS > > No binaries PASS > > mvn test PASS > > > > > > On Fri, Oct 4, 2019 at 6:15 PM [email protected] <[email protected]> > > wrote: > > > >> Hi everyone,We have a new release candidate for first release of Apache > >> Hudi (incubating). The version is : 0.5.0-incubating-rc5. Please note > that > >> previous release candidates RC#3 and RC#4 were not sent for voting as we > >> discovered compliance issues before we could send them for voting. These > >> issues were subsequently fixed as part of PR-935 and PR-939 and RC#5 > has > >> been builtWe also have a new release validation script available in > master > >> to automate the usual checks. To run this > >> - If you have not checkout out hudi, please do > >> - git clone [email protected]:apache/incubator-hudi.git; > >> > >> - If you already have hudi, please do > >> > >> - git checkout master && git pull origin master > >> > >> - cd incubator-hudi/scripts; > >> - ./release/validate_staged_release.sh --release=0.5.0 --rc_num=5 > >> > >> Please review and vote on the release candidate #5 for the version > 0.5.0, > >> as follows:[ ] +1, Approve the release > >> [ ] -1, Do not approve the release (please provide specific comments) > >> The complete staging area is available for your review, which includes: > >> - JIRA release notes [1] > >> - The official Apache source release and binary convenience releases > >> to be deployed to dist.apache.org [2], which are signed with the key > >> with fingerprint AF9BAF79D311A3D3288E583F24A499037262AAA4 [3], > >> > >> - all artifacts to be deployed to the Maven Central Repository [4] > >> > >> - source code tag "release-0.5.0-incubating-rc5" [5] > >> > >> The vote will be open for at least 72 hours. > >> Please cast your votes before *Oct. 9 2019, 19:00 PST*. > >> > >> It is adopted by majority approval, with at least 3 PMC affirmative > >> votes. > >> - > >> > https://jira.apache.org/jira/secure/ReleaseNote.jspa?projectId=12322822&version=12346087 > >> - > >> > https://dist.apache.org/repos/dist/dev/incubator/hudi/hudi-0.5.0-incubating-rc5/ > >> - https://dist.apache.org/repos/dist/release/incubator/hudi/KEYS > >> - > >> https://repository.apache.org/content/repositories/orgapachehudi-1005/ > >> - > >> > https://github.com/apache/incubator-hudi/tree/release-0.5.0-incubating-rc5 > >> Thanks,Balaji.V > >> < > https://github.com/apache/incubator-hudi/tree/release-0.5.0-incubating-rc5Thanks,Balaji.V > > > >> > >> > > >
